iraf-v216 · Code · Issues (50) · Pull requests (81)

iraf.net pull request #95

Fix pointer types for XINT * arguments

closed olebole wants to merge 3 commits

---

olebole commented on 2017-09-03

Sometimes, a formal function argument is an XINT * (aka long int *, pointer to 64bit on 64-bit IRAF), but the type of the actual argument is int * (pointer to 32 bit) only. Just (implicitly) changing pointer type destroys the alignment and may cause an illegal access. And on big endian, even the wrong value is transferred.

This PR fixes this on the places we found:

• ZCLSND() definition and use,
• ZAWTBF() definition and use, and
• BYTMOV() definition and use.

• ---

Commits

• Fix pointer type for ZCLSND call [6f93fda0]
• Fix pointer type for ZAWTBF call [793727cb]
• Fix pointer type for BYTMOV call [1fd3f6ce]

---

Closed on 2017-09-08