iraf-v216 · Code · Issues (50) · Pull requests (81)
iraf.net pull request #130
Make photcal 64-bit capable
olebole merged 2 commits to iraf-community/iraf
olebole commented on 2018-02-04
The 64-bit porting of noao.digiphot.photcal stopped somewhere in the middle and left the parser untouched. This PR completes it, and also fixes a bug that slided into the old adjustment:
The first patch wraps the access to the Memr and Memi code blocks with P2R and P2I, where necessary (in cases the memory was allocates as SPP “structures”, like parval or sym). This closes #129 and solves the “Segmentation fault” problem in #128, which was usually observed whenever one tried to use the 64 bit version of fitparams.
The second patch fixes the problem that fits with more than one fit parameter failed. So, together with the first patch, it closes #128.
This patch has been successfully tested on the standard Travis platforms (Linux/macos; 32/64 bit; old/current), but also on 32/64 bit Scientific Linux 6, which is close to the ancient Redhat version NOAO uses as standard platform. A simple test case was added to the CI pull request #36.
Commits
- photcal: Use P2I and P2R to access real values in structures [08adc380]
- photcal: Fix access to fit parameter table [00ed5e07]
Last updated on 2018-02-05