iraf-v216 · Code · Issues (50) · Pull requests (81)
iraf.net pull request #117
Cleanup unix subdir
olebole merged 10 commits to iraf-community/iraf
olebole commented on 2017-11-27
This pull request removes outdated unused code from the unix subdir:
mc6800,portkit,shlib,sun: this is for architectures that are unsupported and non-existend since quite a while- graphics devices iism70/55 and m70vms
vmcached: outdated by the possibility to use a ramdisk- all unsupported
as.*andbin.*
The code removal covers only code that is not compiled anymore, so it does not change the features of the binaries (since it does not change the binaries at all).
It also cleans up the f2c.h usage by using a common version everywhere (they differed anyway only on common details).
System specific flags like REDHAT, LINUX64, MACH64 etc. are now replaced by standard pre-defined flags like __linux__, __LP64__, __APPLE__. Also, #ifdefs for unused systems is removed. This simplifies the code itself and also required build flags, making future maintenance and porting easier.
Needless to say (or maybe required, based on the discussion so far): This is tested, on Mac and Linux, from old systems (Debian back to 2009; SLC 6, Fedora 23) up to the current versions. So it is sure that the #defines used are really there and work as expected, and that the external libs have the required functionality.
This fixes #12
Commits
- Remove outdated mc6800, portkit, shlib, and sun [e63f7b1f]
- Remove unsupported graphics devices iism70/55 and m70vms [dcd6b943]
- Remove all as.* and bin.* for platforms that are unsupported [54a5422b]
- Move all sources that are not system dependent to their standard places [61fdf174]
- Remove unused vmcached [f3f72eab]
- Consequently use f2c/libf2c/f2c.h, removing all other instances [6459b827]
- Remove -DREDHAT references [365436f9]
- Simplify irafuser.sh [686e9108]
- Remove code for outdated systems from unix/ subdir [a921776f]
- Replace MACH64 and LINUX64 with predefined LP64 & Co. [d88c5122]
Last updated on 2017-12-15