View on GitHub

IRAF Community Distribution

IRAF maintained by the community

iraf-v216 · Code · Issues (50) · Pull requests (81)

iraf.net pull request #112

Fix type of variable to hold vo_paramNext() return value

closed closed olebole wants to merge 1 commits

olebole commented on 2017-11-14

vo_paramNext() returns an int, and specifically returns a negative value if there are arguments left after processing the options.

Depending on the signedness of char, this may be converted to a positive value if the return value is converted to a char. This happens f.e. on ARM processors, where the char is unsigned char by default. Since the option parsing is stopped when this is <=0, additional (non-option) arguments lead
to an errornous processing.

The correct type to hold the return value is int, and this was already set in some VO applications (f.e. votjoin). This patch changes this for the remaining apps.

This fixes the read problem of VOTables on arm processors.

olebole commented on 2018-04-01

The VO package is removed from the iraf-community repository, therefore I am closing this.

Commits

Fix type of variable to hold vo_paramNext() return value [1be5be81]

Last updated on 2017-11-14